Psi Jabber Client

See this page for instructions on how to use Flyspray: http://psi-im.org/wiki/Flyspray

Please Note!

Please do not create tasks here without discussing your bug or feature request on the forums or groupchat psi@conference.psi-im.org, *and* getting explicit confirmation by a developer to add it to flyspray.
Tasklist

FS#740 - Hide 'gone' chat states

Attached to Project: Psi Jabber Client
Opened by Kevin Smith (kev) - Wednesday, 19 December 2007, 13:21 GMT-5
Last edited by Kevin Smith (kev) - Thursday, 03 January 2008, 15:49 GMT-5
Task Type TODO
Category UserInterface → Chat Dialog
Status Assigned
Assigned To No-one
Operating System All
Severity Low
Priority Nice to Have
Reported Version 0.11
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 2
Private No

Details

We should allow the 'gone' notifications to not be shown in the chat dialog and this should be the default option (the 'has ended the conversation' is just offensive most of the time).
This task depends upon

View Dependency Graph

Comment by duryodhan (duryodhan) - Saturday, 09 February 2008, 03:29 GMT-5
Anyone know of a better wording ?
Comment by duryodhan (duryodhan) - Sunday, 10 February 2008, 05:05 GMT-5
In chatdlg.cpp, after line 951 :

if (state == XMPP::StateGone) {
+ if(PsiOptions::instance()->getOption("options.ui.chat.state-notification").toBool())
appendSysMsg(tr("%1 ended the conversation.").arg(Qt::escape(dispNick_)));

Ofcourse the wording needs to be changed. While I thought of making the change to "%1 has closed his window.", I think the spec says that the XMPP::StateGone is that user has stopped talking, even if all other clients use it when the window is closed. ( I am pretty sure that we had this discussion in the chat room sometime back, where a polite wording was shown. If only it were possible to search the chat room history).


oh btw, you obviously need to add the appropriate option in your options.xml as well as $SRC/options/default.xml in the <ui><chat> part, this is what it looks like in mine ,
<state-notification type="bool" >false</state-notification>

I added it just above </chat>, psi reorders it to correct position.

Loading...